chore(deps): update dependency polyfill to 10.7.2#6149
Conversation
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Code Review
Verdict: LGTM — straightforward patch dependency bump, safe to merge.
Change Summary
Single-line version bump in :
-<_TUnitPolyfillVersion>10.7.1</_TUnitPolyfillVersion>
+<_TUnitPolyfillVersion>10.7.2</_TUnitPolyfillVersion>Assessment
Correctness: The upstream patch (#552) fixes a real bug — incorrect variant bits in the Guid.CreateVersion7 polyfill for .NET 8, where the RFC 9562/IETF variant bits weren't being set correctly. This is a correctness fix worth taking.
Scope: The change is appropriately minimal — only the pinned version constant is updated. No TUnit logic is touched.
Risk: Very low. Polyfill is a compile-time source-generator package; it emits helper types rather than shipping runtime DLLs, so there is no binary compatibility surface to worry about. The fix narrows to one polyfill method that most projects won't call in tests, and the change itself is a bug-fix (making output more correct), not a breaking API change.
No prior review comments were open on this PR to verify; Codacy also reports 0 issues.
Auto-merge is already enabled — no action required.
There was a problem hiding this comment.
Code Review
Verdict: LGTM — straightforward patch dependency bump, safe to merge.
Change Summary
Single-line version bump in TUnit.Core/TUnit.Core.targets:
-<_TUnitPolyfillVersion>10.7.1</_TUnitPolyfillVersion>
+<_TUnitPolyfillVersion>10.7.2</_TUnitPolyfillVersion>Assessment
Correctness: The upstream patch (#552) fixes a real bug — incorrect variant bits in the Guid.CreateVersion7 polyfill for .NET 8, where RFC 9562/IETF variant bits were not being set correctly. This is a meaningful correctness fix worth taking.
Scope: The change is appropriately minimal — only the pinned version constant is updated. No TUnit logic is touched.
Risk: Very low. Polyfill is a compile-time source-generator package; it emits helper types rather than shipping runtime DLLs, so there is no binary compatibility surface to worry about. The fix narrows to one polyfill method that most projects will not call in tests, and the change is a bug-fix (making output more correct), not a breaking API change.
No prior review comments were open on this PR to verify; Codacy also reports 0 issues.
Auto-merge is already enabled — no action required.
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.48.6 to 1.49.0. <details> <summary>Release notes</summary> _Sourced from [TUnit's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.49.0 <!-- Release notes generated using configuration in .github/release.yml at v1.49.0 --> ## What's Changed ### Other Changes * docs: benchmark page descriptions + promote Benchmarks in sidebar by @thomhurst in thomhurst/TUnit#6143 * feat(mocks): discriminate generic-method mocks by type argument by @thomhurst in thomhurst/TUnit#6153 * fix(source-gen): jagged array data fails to compile (#6150) by @thomhurst in thomhurst/TUnit#6152 * fix: dispose shared fixtures when only a subset of consuming tests runs by @thomhurst in thomhurst/TUnit#6156 ### Dependencies * chore(deps): update tunit to 1.48.6 by @thomhurst in thomhurst/TUnit#6142 * chore(deps): update react to ^19.2.7 by @thomhurst in thomhurst/TUnit#6144 * chore(deps): update aspire to 13.4.0 by @thomhurst in thomhurst/TUnit#6145 * chore(deps): update dependency nunit.analyzers to 4.14.0 by @thomhurst in thomhurst/TUnit#6146 * chore(deps): update dependency polyfill to 10.7.2 by @thomhurst in thomhurst/TUnit#6148 * chore(deps): update dependency polyfill to 10.7.2 by @thomhurst in thomhurst/TUnit#6149 * chore(deps): update dependency dompurify to v3.4.8 by @thomhurst in thomhurst/TUnit#6155 **Full Changelog**: thomhurst/TUnit@v1.48.6...v1.49.0 Commits viewable in [compare view](thomhurst/TUnit@v1.48.6...v1.49.0). </details> Updated [TUnit.AspNetCore](https://github.com/thomhurst/TUnit) from 1.48.6 to 1.49.0. <details> <summary>Release notes</summary> _Sourced from [TUnit.AspNetCore's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.49.0 <!-- Release notes generated using configuration in .github/release.yml at v1.49.0 --> ## What's Changed ### Other Changes * docs: benchmark page descriptions + promote Benchmarks in sidebar by @thomhurst in thomhurst/TUnit#6143 * feat(mocks): discriminate generic-method mocks by type argument by @thomhurst in thomhurst/TUnit#6153 * fix(source-gen): jagged array data fails to compile (#6150) by @thomhurst in thomhurst/TUnit#6152 * fix: dispose shared fixtures when only a subset of consuming tests runs by @thomhurst in thomhurst/TUnit#6156 ### Dependencies * chore(deps): update tunit to 1.48.6 by @thomhurst in thomhurst/TUnit#6142 * chore(deps): update react to ^19.2.7 by @thomhurst in thomhurst/TUnit#6144 * chore(deps): update aspire to 13.4.0 by @thomhurst in thomhurst/TUnit#6145 * chore(deps): update dependency nunit.analyzers to 4.14.0 by @thomhurst in thomhurst/TUnit#6146 * chore(deps): update dependency polyfill to 10.7.2 by @thomhurst in thomhurst/TUnit#6148 * chore(deps): update dependency polyfill to 10.7.2 by @thomhurst in thomhurst/TUnit#6149 * chore(deps): update dependency dompurify to v3.4.8 by @thomhurst in thomhurst/TUnit#6155 **Full Changelog**: thomhurst/TUnit@v1.48.6...v1.49.0 Commits viewable in [compare view](thomhurst/TUnit@v1.48.6...v1.49.0). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR contains the following updates:
10.7.1→10.7.2Release Notes
SimonCropp/Polyfill (Polyfill)
v10.7.2Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.