feat(Core): Added support to ignore inline HTML comments in metadata header - #97
Open
tylerhubert wants to merge 1 commit into
Open
feat(Core): Added support to ignore inline HTML comments in metadata header#97tylerhubert wants to merge 1 commit into
tylerhubert wants to merge 1 commit into
Conversation
Author
|
@thomvaill, Can I get a review of this change along with others? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now if you don't remove all of the comments in the metadata headers, it either includes them (in the tags) or keeps the ADR in a draft status (for the status). By updating the RegEx that parses the meta data to find those inline HTML comments, we can keep other information available in the source of the ADR, but not display it in the browser.