Limit push builds to the main branch
#1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions has been running the lint twice in Pull Requests: once following the `on push` trigger, once following `on pull_request`. This duplication is currently avoided when running tests by an `if` rule, which skips if the event isn't a push or the Pull Request doesn't come from a fork. This commit removes the `if` rule, and limits the `push` builds to the `main` branch. That will ensure that merged Pull Requests will trigger a build, and that any Pull Request activity will also trigger a build. Being a global rule for the whole build, `standard` will not run twice anymore.
DoodlingDev
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions has been running the lint twice in Pull Requests: once following the
on pushtrigger, once followingon pull_request. This duplication is currently avoided when running tests by anifrule, which skips if the event isn't a push or the Pull Request doesn't come from a fork.This commit removes the
ifrule, and limits thepushbuilds to themainbranch. That will ensure that merged Pull Requests will trigger a build, and that any Pull Request activity will also trigger a build. Being a global rule for the whole build,standardwill not run twice anymore.