redesign when to generate ChunkGroupFooter #524 #525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use java NIO to replace some IO operations (Bytebuffer <-- Stream) design a new TsFileReader class simplify FileMetadata Modify the file format, add RowGroupHeader and ChunkHeader.
# This is the 1st commit message: remove thrift # This is the commit message #2: remove thrift use java NIO to replace some IO operations (Bytebuffer <-- Stream) design a new TsFileReader class simplify FileMetadata Modify the file format, add RowGroupHeader and ChunkHeader.
* add written time in RowGroupMetadata * fix tests * extract initValueReader method in RowGroupReader * change access of measurementIds in RowGroupReader * change access of totabByteSize in RowGroupReader * add writtenTime in TimeSeriesChunkMetaData * add getter and setter for writtenTime in TimeSeriesChunkMetaData * add maxTombstoneTime * add writtenTime in TimeSeriesChunkMetaData * add maxTimbstoneTime in series chunk reader and series reader
Read reconstruction
…iesLazeMerger; fix the return value in write() in BufferWriteProcessor
…mplize read data by TsFileMetadataUtil in iotdb
…the parameter is only used for read
* delete RawSeriesChunk, and change RawSeriesChunkLazyLoadImpl as ReadOnlyMemChunk * rename IMemSeries to IWritableMemSeries, and PrimitiveMemSeries to WriableMemChunk
|
wrong PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #524 .
Then, there are two works left:
is the data size in ChunkGroupFooter meaningful?
if
MemtableFlushUtils.flushMemTable()needs to call low-level functions, I think the TsFileIOWriter needs to be redesigned.I will try to fix the above two problem tomorrow.