Repository navigation
fix(alerting): de-page thundermail-ticket-spike-monitor (ArgoCD Degraded) - #30
Merged
Merged
Conversation
…ded) Exclude name="thundermail-ticket-spike-monitor" from the ArgoCDApplicationDegraded paging query. It is a non-critical CronJob (Zendesk ticket-count poller) whose transient run failures leave a Failed Job in history, holding the ArgoCD app Degraded for up to ~45m (failedJobsHistoryLimit:3 x 15m cadence) -> exceeds the alert's for:15m -> pages platform on-call for a low-stakes monitor. This fully suppresses the page (and alert) for that one app; all other shared01 apps still page per-app as before. Accepted because the monitor is non-critical; the durable fix (make the monitor resilient / not retain failed Jobs) is tracked in thunderbird/platform-infrastructure#611. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mzeier
approved these changes
Jun 29, 2026
|
Ran Plan for project: Show OutputTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# grafana_rule_group.catalog_argocd will be updated in-place
~ resource "grafana_rule_group" "catalog_argocd" {
id = "1:efhbgu7k4a2o0b:catalog-argocd-paging"
name = "catalog-argocd-paging"
# (4 unchanged attributes hidden)
~ rule {
name = "ArgoCDApplicationDegraded"
# (10 unchanged attributes hidden)
~ data {
~ model = jsonencode(
~ {
~ expr = "sum by (name) (argocd_app_info{cluster=\"mzla-eks-shared01\",health_status=\"Degraded\"})" -> "sum by (name) (argocd_app_info{cluster=\"mzla-eks-shared01\",health_status=\"Degraded\",name!=\"thundermail-ticket-spike-monitor\"})"
# (3 unchanged attributes hidden)
}
)
# (3 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# (2 unchanged blocks hidden)
}
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Plan: 0 to add, 1 to change, 0 to destroy.
|
Contributor
Author
|
atlantis apply |
|
Ran Apply for project: ╷
│ Warning: Deprecated Parameter
│
│ The parameter "dynamodb_table" is deprecated. Use parameter "use_lockfile"
│ instead.
╵
grafana_rule_group.catalog_argocd: Modifying... [id=1:efhbgu7k4a2o0b:catalog-argocd-paging]
grafana_rule_group.catalog_argocd: Modifications complete after 1s [id=1:efhbgu7k4a2o0b:catalog-argocd-paging]
Apply complete! Resources: 0 added, 1 changed, 0 destroyed. |
|
Locks and plans deleted for the projects and workspaces modified in this pull request:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Excludes
name="thundermail-ticket-spike-monitor"from theArgoCDApplicationDegradedpaging query so it no longer pages platform on-call.Why
It's a non-critical CronJob (Zendesk ticket-count poller). A single transient run failure leaves a
FailedJob in history, holding the ArgoCD appDegradedfor up to ~45m (failedJobsHistoryLimit: 3× 15-min cadence), which exceeds the alert'sfor: 15mand pages on-call for a low-stakes monitor.Scope / trade-off
This fully suppresses the page and the alert for this one app; every other shared01 app still pages per-app as before. Accepted because the monitor is non-critical. The durable fix (make the monitor resilient / stop retaining failed Jobs) is tracked in thunderbird/platform-infrastructure#611.
Verification
Atlantis
planshould show a single in-place update tografana_rule_group.catalog_argocd(0 add / 0 destroy).🤖 Generated with Claude Code