2025 upkeep #295
Merged
2025 upkeep #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
reviewed
Dec 1, 2025
| #> # A tibble: 25 × 2 | ||
| #> object size | ||
| #> <chr> <dbl> | ||
| #> 1 terms 0.00763 |
Member
There was a problem hiding this comment.
Notice this change here; this is why we can't use devtools::build_readme()
Comment on lines
14
to
23
| # `devtools::build_readme()` evaluates in `callr:r_safe()` which causes issues | ||
| # with butcher's memory profiling. Neither RStudio's Knit button nor | ||
| # `rmarkdown::render()` have this issue (#280). | ||
| if (identical(Sys.getenv("CALLR_IS_RUNNING"), "true")) { | ||
| rlang::abort(c( | ||
| "Build this README with `rmarkdown::render()` rather than `devtools::build_readme()`.", | ||
| "See tidymodels/butcher#280 for more info." | ||
| )) | ||
| } |
Member
There was a problem hiding this comment.
We do in fact need to keep this in, because of the problem with how devtools::build_readme() uses callr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably PR 1/x.
Change maintainer and remove references to
surv_reg(), which is fully deprecated.