Skip to content

start work on vignette #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

start work on vignette #544

wants to merge 12 commits into from

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Jan 31, 2025

I'll pause work on this until the funneling part is stable @krlmlr


## Design principles

The duckplyr package uses **DuckDB under the hood** but is also a **drop-in replacement for dplyr**.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comes from the blog post draft 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the future post on duckplyr, the post on laziness r-hub/blog#179

@krlmlr krlmlr force-pushed the vignette branch 2 times, most recently from 71657d8 to 4d31fc6 Compare January 31, 2025 16:20
@krlmlr
Copy link
Member

krlmlr commented Jan 31, 2025

Thanks, this is very accessible! I have a script to do the bulk rename ops, I applied it to the current text.

@krlmlr krlmlr force-pushed the vignette branch 2 times, most recently from 7196cba to 9a3ff71 Compare February 1, 2025 05:56
@maelle
Copy link
Collaborator Author

maelle commented Feb 6, 2025

Also add how to change configuration options see #587

@krlmlr
Copy link
Member

krlmlr commented Feb 7, 2025

Thanks, this is a good addition. I noticed two things:

  • I'm using bold face (two-star emphasis) in exceptional situations only, perhaps once per article at most. If really necessary, emphasis with italics works, but can we also emphasize just by phrasing?
  • References to the other articles should appear in the order of their appearance -- large, prudence, fallback, limits, ...

@krlmlr krlmlr requested a review from hadley February 7, 2025 02:40
---
title: "duckplyr"
output: rmarkdown::html_vignette
author: Maëlle Salmon
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think vignettes should have authors. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants