Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider a default role for OpenAI messages #405

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Conversation

hadley
Copy link
Member

@hadley hadley commented Apr 1, 2025

Part of #161

@atheriel this brings ellmer closer in line with the ChatGPT sdk, but can you please double check it still works for snowflake?

@hadley hadley requested a review from atheriel April 1, 2025 22:39
@atheriel
Copy link
Collaborator

atheriel commented Apr 8, 2025

Confirmed that chat_snowflake() still works with this change. ✅

@hadley hadley merged commit ad1db5b into main Apr 9, 2025
9 checks passed
@hadley hadley deleted the openai-default-role branch April 9, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants