Refactor cost computation #812
Merged
+194
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we compute the cost once, when we create the turn. The makes a lot of things simpler, e.g. we no longer need to track the variant in `the$tokens`, and unit tests get simpler. I also introduce `Chat$get_cost_details()` (ported from #810) to make it easier to inspect the raw details of a chat. Includes a fix for #804 by logging as part of `Chat$add_turn()`. This breaks #743 in a new way: for now batch chat usage isn't logged at all. But I think it makes sense to fix that in another PR. I've also added `map_tokens()` helper to hide the awkward use of `vapply()` in a few places (and to make the output more consistent)
cpsievert
reviewed
Oct 29, 2025
R/chat.R
Outdated
| private$provider, | ||
| # TODO: store better representation in Turn object | ||
| exec(tokens, !!!as.list(system@tokens)), | ||
| system@cost |
There was a problem hiding this comment.
system here really means assistant, right? Worth fixing that naming now?
There was a problem hiding this comment.
Oh yeah that confused me too. Might as well fix now.
cpsievert
reviewed
Oct 29, 2025
R/turns.R
Outdated
Comment on lines
63
to
72
| tokens = c(0, 0, 0), | ||
| duration = NA_real_ | ||
| duration = NA_real_, | ||
| cost = NA_real_ |
There was a problem hiding this comment.
I'd prefer tokens and cost to be next to one another
cpsievert
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we compute the cost once, when we create the turn. The makes a lot of things simpler, e.g. we no longer need to track the variant in
the$tokens, and unit tests get simpler. I also introduceChat$get_cost_details()(ported from #810) to make it easier to inspect the raw details of a chat.Includes a fix for #804 by logging as part of
Chat$add_turn(). This breaks #743 in a new way: for now batch chat usage isn't logged at all. But I think it makes sense to fix that in another PR.I've also added
map_tokens()helper to hide the awkward use ofvapply()in a few places (and to make the output more consistent)