Improve support for reasoning #815
Open
+56
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New `reasoning_effort` and `reasoning_tokens` arguments to `params()` * `chat_claude()` uses `reasoning_tokens` and streams thinking summaries * `chat_google_gemini()` uses `reasoning_tokens`. Gemini doesn't appear to have a thinking content type so no additional support needed. * `chat_openai_responses()` uses `reasoning_effort` and streams thinking summaries. It correctly captures summaries into `ContentThinking` The streaming support is suboptimal since there doesn't appear to be an easy way to distinguish thinking and regular output. Fixes #720
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reasoning_effortandreasoning_tokensarguments toparams()chat_claude()usesreasoning_tokensand streams thinking summarieschat_google_gemini()usesreasoning_tokens. Gemini doesn't appear to have a thinking content type so no additional support needed.chat_openai_responses()usesreasoning_effortand streams thinking summaries. It correctly captures summaries intoContentThinkingThe streaming support is suboptimal since there doesn't appear to be an easy way to distinguish thinking and regular output.
Fixes #720
I tested interactively with