Skip to content

Update to update_*_defaults() (reviving #5781) #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

teunbrand
Copy link
Collaborator

This is a git cherry pick of the merge commit of #5781.
Earlier, we decided to defer #5781 until after the 3.5.1 release.
Marking this as draft until release is complete.

* unify updating mechanism

* add tests

* redocument

* add news bullet

* add review suggestion
@teunbrand teunbrand marked this pull request as ready for review April 24, 2024 09:04
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit a420264 into tidyverse:main Apr 29, 2024
7 of 12 checks passed
@teunbrand teunbrand deleted the replay_5781 branch April 29, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants