Skip to content

Be clearer when the fill aesthetic applies in points #5868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #4358.

It just rephrases a sentence in the vignette and adds a note to the geom_point() aesthetics section.

@teunbrand teunbrand changed the title Be clearer on what shapes the fill aesthetic applies Be clearer when the fill aesthetic applies in points Apr 26, 2024
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit e24cbba into tidyverse:main Apr 29, 2024
12 checks passed
@teunbrand teunbrand deleted the shape_fill_docsc branch April 29, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue a message when fill aesthetic is used with GeomPoint and shape is not "filled"
2 participants