make sure using the prepared r_axis_inside for all methods

[Yunuuuu]

fix #6411

[Yunuuuu]

All other methods that use r_axis_inside already have access to panel_params, so the straightforward fix is to store r_axis_inside inside panel_params

[Yunuuuu]

How about this? It should produce consistent behavior across repeated calls and will only warning once for multiple panels:

library(ggplot2)
my_warn_coord <- coord_radial(start = 0.1 * pi, end = 0.4 * pi, r.axis.inside = FALSE)

# first run
ggplot(mtcars, aes(disp, mpg)) +
  geom_point() +
  my_warn_coord

# second run
ggplot(mtcars, aes(disp, mpg)) +
  geom_point() +
  my_warn_coord

[teunbrand]

I'm not convinced there should be a panel_params$r_axis_inside parameter. It is a global property that is not needed for calculating panel transformations, so it doesn't belong in the panel parameters in my opinion.

[Yunuuuu]

Thanks for the explanation — I'll keep it out of panel_params as suggested.

[Yunuuuu]

Can I change the warning message to indicate we have set r.axis.inside = TRUE directly

[teunbrand]

If you think that makes things clearer

[teunbrand]

Great, thank you this PR and for following along with all the nitpicks! I think this PR is good to go, but we're figuring out some issues with the current main branch. After those are resolved, I think this can be merged in.

[Yunuuuu]

Appreciate the review and all the guidance—thanks!