Fix wrong results when filtering a date column to a timestamptz value#9990
Open
svenklemm wants to merge 1 commit into
Open
Fix wrong results when filtering a date column to a timestamptz value#9990svenklemm wants to merge 1 commit into
svenklemm wants to merge 1 commit into
Conversation
|
@dbeck, @pnthao: please review this pull request.
|
svenklemm
force-pushed
the
sven/date_timestamp_cmp
branch
from
8a33beb to
4848c0e
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
The comparison was rewritten by casting the timestamptz to a date, which drops the time of day and can change the result. This is correct only for "date > value" and "date <= value". For the other operators we now keep the original comparison. This affected vectorized filtering and chunk exclusion. Fixes: #9976
svenklemm
force-pushed
the
sven/date_timestamp_cmp
branch
from
4848c0e to
8dc023d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparison was rewritten by casting the timestamptz to a date, which
drops the time of day and can change the result.
This is correct only for "date > value" and "date <= value". For the other
operators we now keep the original comparison.
This affected vectorized filtering and chunk exclusion.
Fixes: #9976