controller: expose reconciliation state and progress#38
Open
pritesh-pagar wants to merge 9 commits intotimoha:mainfrom
Open
controller: expose reconciliation state and progress#38pritesh-pagar wants to merge 9 commits intotimoha:mainfrom
pritesh-pagar wants to merge 9 commits intotimoha:mainfrom
Conversation
pritesh-pagar
commented
Mar 24, 2025
pritesh-pagar
commented
- Add reconciliation phase and progress in a status field
- Expose reconciliation status as a prom metric
* Status will have a new field Phase to show reconciliation phase, such as - Ready, ApplyingChanges, Invalid
Add reconciliation phase in status field
controllers: expose controller phase as metric
- add a new field reconcile progress in status do donote what exactly reconciler is doing - expose progress as a prom metrics as well
controller: show reconciliation progress in status
timoha
approved these changes
Mar 25, 2025
Owner
timoha
left a comment
timoha
left a comment
There was a problem hiding this comment.
LG, thanks for the contribution!
Allow overriding the default hbase znode parent used by gohbase admin client Needed for running multiple hbase clusters on the same zookeeper cluster, e.g. for replication between hbases. Tested by running `go run ./cmd/ -zkroot=/hbase-test` and observing ``` failed to read the /hbase-test/master znode: zk: could not connect to a server ``` in the output.
* Upgrade gohbase ``` go get github.com/tsuna/gohbase go mod tidy ``` * Migrate from github.com/golang/mock to https://github.com/uber-go/mock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.