-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Publish with Cargo in dry-run mode" CI job by setting a dummy version which doesn't already exist #87
Conversation
Warning Rate limit exceeded@timrogers has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 44 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 45b8d91 in 8 seconds
More details
- Looked at
15
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. .github/workflows/build_and_release.yml:81
- Draft comment:
Consider specifying a version forcargo-edit
to ensure consistent builds. - Reason this comment was not posted:
Confidence changes required:50%
Thecargo install cargo-edit
step should specify a version to ensure consistent builds.
Workflow ID: wflow_mrcIg8ijSaMsunke
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
…y version which doesn't already exist
45b8d91
to
9ab7e43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 9ab7e43 in 17 seconds
More details
- Looked at
18
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. .github/workflows/build_and_release.yml:81
- Draft comment:
Consider specifying a version forcargo-edit
to ensure consistency and avoid potential future issues with breaking changes. For example,cargo install cargo-edit --version <version>
. - Reason this comment was not posted:
Confidence changes required:50%
The use ofcargo install cargo-edit
in the CI workflow can be optimized by specifying a version to ensure consistency and avoid potential future issues with breaking changes.
2. .github/workflows/build_and_release.yml:85
- Draft comment:
The--allow-dirty
flag is necessary due to the version change, but consider adding a comment explaining why it's used for clarity. - Reason this comment was not posted:
Confidence changes required:50%
The use of--allow-dirty
incargo publish --dry-run
is necessary due to the version change, but it should be documented in the comments for clarity.
Workflow ID: wflow_dpkmtpnoTXunI5O1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Fixes CI workflow by setting a dummy version for dry-run publishing in
build_and_release.yml
.build_and_release.yml
, added step to installcargo-edit
.9.9.9
beforecargo publish --dry-run
to avoid version conflicts.This description was created by
for 9ab7e43. It will automatically update as commits are pushed.