-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the darwin-arm64 binary as an asset when publishing a release #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 2c883c5 in 5 seconds
More details
- Looked at
22
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. .github/workflows/build_and_release.yml:150
- Draft comment:
Ensure that the darwin-arm64 binary is correctly built and uploaded as an artifact in the build job. Verify that the build matrix includes the darwin-arm64 target and that the artifact is uploaded with the correct name. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds support for the darwin-arm64 binary in the release process. The changes are consistent with existing patterns for other binaries.
Workflow ID: wflow_pCwgyIwMcqtd2quF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Warning Rate limit exceeded@timrogers has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 41 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Important
Add
darwin-arm64
binary to release assets in GitHub Actions workflow.build_and_release.yml
, adddarwin-arm64
binary to thecreate_github_release
job.download-artifact
steps to includelitra_${{ steps.sanitise_ref.outputs.value }}_darwin-arm64
.action-gh-release
step to includedarwin-arm64
in release assets.This description was created by
for 2c883c5. It will automatically update as commits are pushed.