-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create, sign and notarize and release a universal macOS binary #91
Conversation
Warning Rate limit exceeded@timrogers has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 13 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 2f2ab14 in 25 seconds
More details
- Looked at
98
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_aCW2OgUzv0VS3oRD
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
steps: | ||
- name: Sanitise Git ref for use in filenames | ||
id: sanitise_ref | ||
run: echo "::set-output name=value::$(echo "${{ github.ref_name }}" | tr '/' '_')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of ::set-output
is deprecated. Use echo "value=<value>" >> $GITHUB_ENV
instead. This applies to all instances where ::set-output
is used.
Important
Add GitHub Actions job to create, sign, and notarize a universal macOS binary and update release process.
create_and_sign_macos_universal_binary
job to.github/workflows/build_and_release.yml
for creating, signing, and notarizing a universal macOS binary.create_github_release
job to depend oncreate_and_sign_macos_universal_binary
.litra_${{ steps.sanitise_ref.outputs.value }}_darwin-universal
in release assets.lipo
to create a universal binary fromdarwin-amd64
anddarwin-arm64
binaries.This description was created by
for 2f2ab14. It will automatically update as commits are pushed.