-
Notifications
You must be signed in to change notification settings - Fork 6
Make diffs relative from same directory #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Change postfix version to new version and change hiredis path as should now be able install with a package
|
@a16bitsysop Thanks for the patch. Since I have not been using this for a while, I do not have any setup handy to check if this patch compiles with postfix version that you have created diff. Have you tested this patch? |
README.md
Outdated
| @@ -1,14 +1,14 @@ | |||
| ### Postfix Redis | |||
| This is a patch to the postfix 2.9.3 MTA to add a lookup table for redis database. | |||
| This is a patch to the postfix 3 MTA to add a lookup table for redis database. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be more specific of the postfix version here and not just major version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will have a look into it
README.md
Outdated
| This patch depends on hiredis client library. | ||
|
|
||
| Apply the patch to a vanilla postfix 2.9.3 source tree | ||
| Apply the patch to a vanilla postfix 3 source tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be more specific of the postfix version here and not just major version.
README.md
Outdated
| % make makefiles CCARGS="-DHAS_REDIS -I/usr/include/hiredis" AUXLIBS="-L/usr/lib -lhiredis" | ||
| Change the include and library location for hiredis client library if required. | ||
|
|
||
| ### Compile postfix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which distribution did you use? Would'nt the include directory change from distribution to distribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used alpine, but there is a package on ubuntu as well. Will install it and check it installs to /usr or /usr/local
|
@a16bitsysop If you intent to use this in your project I would like to change this project to be dyncamically loaded database plugin for postfix 3 and above. |
|
Yes I am planning to, but just got to the getting it to compile (in alpine) stage. |
delete hiredis.h as it is in hiredis package
|
Compiles postfix-redis.so but doesn’t install it, and not linked to libhiredis if ldd it. |
Check which versions of postfix it works with
|
compiles, links, and installs now. Tested with postconf and postmap queries |
|
@a16bitsysop Thanks for those quick changes. Sorry for the delays, I have not been able to focus on this because of the ongoing issues around here. I did glimpse through the patch. Just wanted to know if alpine ships the postfix package with dynamicmaps support like what debian and derivative do. For example, ubuntu latest version ships postfix with dynaicmaps and all supported database plugins as separate packages too. |
|
Yes they do the same, the main alpine packages are: postfix-lmdb-3.4.9-r0 |
Add prefix in config parse to add a prefix to the key Always print key looking up for debug purposes Add main.cf and redis exmaples
remove valid_hostname.h as not used
make logging conditional again, uses postfix log verbosity remake patch against 3.5.6
move patches into own directory
and update for new version of postfix.