Skip to content

add https://github.com/avih/tldr-fmt (shell formatter) #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

avih
Copy link
Contributor

@avih avih commented Aug 20, 2020

Please let me know if you want/need anything else.

@agnivade agnivade merged commit 6285220 into tldr-pages:master Aug 21, 2020
@agnivade
Copy link
Member

Thanks!

@avih
Copy link
Contributor Author

avih commented Aug 21, 2020

Thanks for the quick merge!

However, I now see that it kinda stands out, in a bad way, due to having a rather not-short description - unlike the other clients at the table.

Additionally, I added a tiny client (same repo/url) which uses this formatter.

Would it be much to ask to change it to something like sh formatter and client, or some other short description which you prefer? I think sh generally implies POSIX, at least for those who care, though I'm not sure.

Ideas are weldome, thanks in advance.

@agnivade
Copy link
Member

We do have a bash client, and that just says "Bash client". If you want to strictly stick to shell, you can just say "Shell client" and drop the formatter part altogether and let users figure out the rest.

We also have another page here: https://github.com/tldr-pages/tldr/wiki/tldr-pages-clients where you can flesh out in more detail.

@avih
Copy link
Contributor Author

avih commented Aug 21, 2020

"Shell client" and drop the formatter part altogether and let users figure out the rest.

Right, I agree either this or "sh client" would be good for that page, and indeed that other page is suitable for more details.

I'll send a PR soon. Thanks again for the assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants