Skip to content

upgrade corner #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 8, 2021
Merged

upgrade corner #55

merged 9 commits into from
Mar 8, 2021

Conversation

tansiret
Copy link
Member

@tansiret tansiret commented Mar 3, 2021

I have replaced old-looking "fork me" corner with github-corners, a fresh and modern replacement.

bl-ue
bl-ue previously approved these changes Mar 3, 2021
Copy link

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this will be generally accepted, but at least LGTM!

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this, although I'd probably move the styles to the index.css and also remove the old banner styles here:
https://github.com/tldr-pages/tldr-pages.github.io/blob/master/assets/css/index.css#L154-L192

@tansiret
Copy link
Member Author

tansiret commented Mar 3, 2021

I prefer this, although I'd probably move the styles to the index.css and also remove the old banner styles here:
https://github.com/tldr-pages/tldr-pages.github.io/blob/master/assets/css/index.css#L154-L192

Done.

@bl-ue bl-ue dismissed their stale review March 3, 2021 14:43

@YUTYO, please fix the formatting with my suggestions.

@tansiret
Copy link
Member Author

tansiret commented Mar 4, 2021

🦗

@owenvoke
Copy link
Member

owenvoke commented Mar 4, 2021

Patience @YUTYO 😄 Everyone here are volunteers, and there's no rush. I think it would be good to get some more opinions on this one as the website is public facing. 👍🏻

@owenvoke
Copy link
Member

owenvoke commented Mar 4, 2021

One thing I'm wondering, should it have position: fixed to match the previous one and always be in the top right corner when people are scrolling?

@tansiret
Copy link
Member Author

tansiret commented Mar 4, 2021

I want to revert last commit.

@bl-ue
Copy link

bl-ue commented Mar 4, 2021

Whoops @YUTYO there's some merge conflicts added by a79e750. Will you please fix them?

Copy link

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! (I don't have a preview though 🤔)

Co-authored-by: Starbeamrainbowlabs <[email protected]>
@bl-ue bl-ue requested a review from sbrl March 8, 2021 20:40
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @YUTYO!

@sbrl sbrl merged commit b00afd5 into tldr-pages:master Mar 8, 2021
@bl-ue
Copy link

bl-ue commented Mar 10, 2021

Looks good on the website, @YUTYO! 🚀

I've seen this new corner on several sites now, including here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants