-
-
Notifications
You must be signed in to change notification settings - Fork 38
upgrade corner #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade corner #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this will be generally accepted, but at least LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this, although I'd probably move the styles to the index.css
and also remove the old banner styles here:
https://github.com/tldr-pages/tldr-pages.github.io/blob/master/assets/css/index.css#L154-L192
Done. |
@YUTYO, please fix the formatting with my suggestions.
Co-authored-by: bl-ue <[email protected]>
Co-authored-by: bl-ue <[email protected]>
🦗 |
Patience @YUTYO 😄 Everyone here are volunteers, and there's no rush. I think it would be good to get some more opinions on this one as the website is public facing. 👍🏻 |
One thing I'm wondering, should it have |
I want to revert last commit. |
…ithub.io into github-corner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me! (I don't have a preview though 🤔)
Co-authored-by: Starbeamrainbowlabs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @YUTYO!
I have replaced old-looking "fork me" corner with github-corners, a fresh and modern replacement.