-
-
Notifications
You must be signed in to change notification settings - Fork 99
feat: update for v3.4.0 release #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, we can ignore the failing snap workflow for the moment since it only pulls files from a tagged branch for stable builds (builds not part of edge branch).
Before going ahead with the next release, I am planning to discuss with other maintainers with access to set up https://docs.pypi.org/trusted-publishers/ for publishing the page directly via CI here since the current workflow uses Masterodin's bot (he has left the org on 2023, and he only has write access to the repo as he was converted to an outside collaborator). The suggested approach with trusted publishing doesn't need any tokens and also ensures a more secure experience.
I definitely think that a Trusted Publisher token makes the most sense. 👍🏻 Easier to update, maintain, and not reliant on a specific user. |
Agreed, will open an issue in the access repo to discuss this. |
Looks like this can be rebased now. 👍🏻 |
Trusted publisher support has been configured and added to the publish workflow (once a release is tagged and created on GitHub, the deployment (after admin's approval in action tab) will upload the package to PyPI. I will go through other PRs, update and merge them if applicable. Also, metadata fields in Once all changes are done, I will merge it into this PRs branch and then merge the PR. Then we can create a release. Btw, is there any other changes you want to do @Managor? |
Not to the program itself. I was thinking of going through the PRs made after the last version and adding them to the changelog. |
Great, I have changelog ready for release, currently testing the snap build from snapcraft will push changes to this branch after it. Edit: I have some tests to do still for the snap file (since manpages aren't working properly; this was an issue when we packaged initally since snap doesn't have that good of support for manpages), I will test it out tomorrow and get back. |
Signed-off-by: K.B.Dharun Krishna <[email protected]>
Signed-off-by: K.B.Dharun Krishna <[email protected]>
Signed-off-by: K.B.Dharun Krishna <[email protected]>
Signed-off-by: K.B.Dharun Krishna <[email protected]>
…leanups Signed-off-by: K.B.Dharun Krishna <[email protected]>
Signed-off-by: K.B.Dharun Krishna <[email protected]>
…n-client into version-3.4.0
Thanks for the fixes @Managor. All changes have been completed in my side, merging this PR to create a new release once the CI is done. |
Preparation for 3.4.0 release