Skip to content

feat: update for v3.4.0 release #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 28, 2025
Merged

Conversation

Managor
Copy link
Contributor

@Managor Managor commented Mar 26, 2025

Preparation for 3.4.0 release

@Managor Managor marked this pull request as draft March 26, 2025 05:10
@kbdharun kbdharun self-assigned this Mar 26, 2025
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we can ignore the failing snap workflow for the moment since it only pulls files from a tagged branch for stable builds (builds not part of edge branch).


Before going ahead with the next release, I am planning to discuss with other maintainers with access to set up https://docs.pypi.org/trusted-publishers/ for publishing the page directly via CI here since the current workflow uses Masterodin's bot (he has left the org on 2023, and he only has write access to the repo as he was converted to an outside collaborator). The suggested approach with trusted publishing doesn't need any tokens and also ensures a more secure experience.

@owenvoke
Copy link
Member

I definitely think that a Trusted Publisher token makes the most sense. 👍🏻 Easier to update, maintain, and not reliant on a specific user.

@kbdharun
Copy link
Member

I definitely think that a Trusted Publisher token makes the most sense. 👍🏻 Easier to update, maintain, and not reliant on a specific user.

Agreed, will open an issue in the access repo to discuss this.

@owenvoke
Copy link
Member

Looks like this can be rebased now. 👍🏻

@kbdharun
Copy link
Member

kbdharun commented Mar 27, 2025

Trusted publisher support has been configured and added to the publish workflow (once a release is tagged and created on GitHub, the deployment (after admin's approval in action tab) will upload the package to PyPI.

I will go through other PRs, update and merge them if applicable. Also, metadata fields in setup.py are outdated compared to https://packaging.python.org/en/latest/specifications/core-metadata/ I will update it along with the other changes within an hour.

Once all changes are done, I will merge it into this PRs branch and then merge the PR. Then we can create a release.

Btw, is there any other changes you want to do @Managor?

@Managor
Copy link
Contributor Author

Managor commented Mar 27, 2025

Btw, is there any other changes you want to do @Managor?

Not to the program itself. I was thinking of going through the PRs made after the last version and adding them to the changelog.

@kbdharun
Copy link
Member

kbdharun commented Mar 27, 2025

Btw, is there any other changes you want to do @Managor?

Not to the program itself. I was thinking of going through the PRs made after the last version and adding them to the changelog.

Great, I have changelog ready for release, currently testing the snap build from snapcraft will push changes to this branch after it.

Edit: I have some tests to do still for the snap file (since manpages aren't working properly; this was an issue when we packaged initally since snap doesn't have that good of support for manpages), I will test it out tomorrow and get back.

@kbdharun kbdharun marked this pull request as ready for review March 28, 2025 13:33
Signed-off-by: K.B.Dharun Krishna <[email protected]>
@kbdharun kbdharun changed the title Version 3.4.0 feat: update for v3.4.0 release Mar 28, 2025
@kbdharun
Copy link
Member

Thanks for the fixes @Managor. All changes have been completed in my side, merging this PR to create a new release once the CI is done.

@kbdharun kbdharun merged commit 49d71cc into tldr-pages:main Mar 28, 2025
27 checks passed
@Managor Managor deleted the version-3.4.0 branch March 28, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants