Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/wrong-filename.sh: convert to Python-script #15438

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sebastiaanspeck
Copy link
Member

@sebastiaanspeck sebastiaanspeck commented Jan 3, 2025

  • The PR title conforms to the recommended templates.

Alongside with this PR, a PR in GitHub.com/tldr-pages/tldr-maintenance is needed as well, tldr-pages/tldr-maintenance#154

@github-actions github-actions bot added documentation Issues/PRs modifying the documentation. tooling Helper tools, scripts and automated processes. labels Jan 3, 2025
@sebastiaanspeck sebastiaanspeck marked this pull request as draft January 5, 2025 07:41
@sebastiaanspeck
Copy link
Member Author

I am doubting if we still want this script or move the logic to check if the page title is what we expect from the filename (and viceversa) in scripts/set-page-title.py. To me they seem to overlap.

@sebastiaanspeck sebastiaanspeck added decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. community Issues/PRs dealing with role changes and community organization. labels Feb 18, 2025
@sebastiaanspeck sebastiaanspeck marked this pull request as ready for review March 11, 2025 05:58
@sebastiaanspeck
Copy link
Member Author

@Managor @acuteenvy @kbdharun can I ask for your opinion on this?

  1. Switch to the Python-script (so it is runnable on MacOS as well)?
  2. This overlaps with set-page-title.py, shouldn't it be integrated there?

Only if this is something we want, I will fix the merge conflicts.

@Managor
Copy link
Collaborator

Managor commented Mar 11, 2025

Can you give me a quick rundown of what the issue is? I'm unable to use the "Resolve conflicts" button to view the conflicts

I don't see any downsides with switching to a python script. Can you elaborate more on that?

@sebastiaanspeck
Copy link
Member Author

I don't see any downsides with switching to a python script. Can you elaborate more on that?

I agree, but since the functionality overlaps with set-page-title.py (this script is for reporting a filename is incorrect and set-page-title fixes it). Why not have just one script for both purposes?

@Managor
Copy link
Collaborator

Managor commented Mar 11, 2025

I don't see any reason of having two scripts that do the same thing. Delete the shell scripts and leave it that.

@sebastiaanspeck sebastiaanspeck marked this pull request as draft March 11, 2025 08:43
@sebastiaanspeck
Copy link
Member Author

I don't see any reason of having two scripts that do the same thing. Delete the shell scripts and leave it that.

I will integrate the missing functionality from this shell script into the Python script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization. decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. documentation Issues/PRs modifying the documentation. tooling Helper tools, scripts and automated processes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants