-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts/wrong-filename.sh: convert to Python-script #15438
base: main
Are you sure you want to change the base?
scripts/wrong-filename.sh: convert to Python-script #15438
Conversation
I am doubting if we still want this script or move the logic to check if the page title is what we expect from the filename (and viceversa) in scripts/set-page-title.py. To me they seem to overlap. |
@Managor @acuteenvy @kbdharun can I ask for your opinion on this?
Only if this is something we want, I will fix the merge conflicts. |
Can you give me a quick rundown of what the issue is? I'm unable to use the "Resolve conflicts" button to view the conflicts I don't see any downsides with switching to a python script. Can you elaborate more on that? |
I agree, but since the functionality overlaps with set-page-title.py (this script is for reporting a filename is incorrect and set-page-title fixes it). Why not have just one script for both purposes? |
I don't see any reason of having two scripts that do the same thing. Delete the shell scripts and leave it that. |
I will integrate the missing functionality from this shell script into the Python script. |
Alongside with this PR, a PR in GitHub.com/tldr-pages/tldr-maintenance is needed as well, tldr-pages/tldr-maintenance#154