Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style-guide: add Arabic translation #15583

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MachiavelliII
Copy link
Member

It follows the main guidelines and some specific rules for Arabic.
Could you verify this?

@github-actions github-actions bot added the documentation Issues/PRs modifying the documentation. label Jan 22, 2025
Replace الإرشادات with التوثيقات
@sebastiaanspeck
Copy link
Member

It follows the main guidelines and some specific rules for Arabic.

Could you verify this?

I can't since I do not speak Arabic. I can not approve this right now.

@sebastiaanspeck sebastiaanspeck removed their request for review February 7, 2025 01:55
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution. I am not a native speaker so I validated the additions using Google translate.

Btw, if it's possible can you add the newer additions to the style guide here too (see the file's commit history). If not we can merge this PR in it's current state since it's been open for a while.

@MachiavelliII
Copy link
Member Author

LGTM, thanks for your contribution. I am not a native speaker so I validated the additions using Google translate.

Btw, if it's possible can you add the newer additions to the style guide here too (see the file's commit history). If not we can merge this PR in it's current state since it's been open for a while.

Do you mean these changes #15749 ?

@Managor
Copy link
Collaborator

Managor commented Mar 17, 2025

Lets get #15951 merged.
I just did a re-read of the whole style guide and did not see anything more to fix. After my pull is merged, you can redo your style guide based on what has changed. I see 18 commit since you created this page.

@sebastiaanspeck
Copy link
Member

@MachiavelliII any update on this?

@MachiavelliII
Copy link
Member Author

@sebastiaanspeck It focuses on the core of contribution, and it's ready to merge!

@Managor
Copy link
Collaborator

Managor commented Mar 28, 2025

You haven't done updates after the main style guide merges

@MachiavelliII
Copy link
Member Author

@Managor Could you please ping me on that PR?

@Managor
Copy link
Collaborator

Managor commented Mar 28, 2025

Just look at the current style guide and compare it to your translation https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md

@MachiavelliII
Copy link
Member Author

I'll document the new important changes cuz documenting the whole file is weird for Arabic translation.

@Managor
Copy link
Collaborator

Managor commented Mar 28, 2025

In that case you can open the file history
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants