Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example bridges
TlsListener
withaxum::serve
.One can also bypass
axum::serve
and use theRouter
with Hyper'sserve_connection
API directly. The main advantages of usingaxum::serve
are that.with_graceful_shutdown
API, andCONNECT
protocol in order to support HTTP/2 websockets).There are a couple slight papercuts I encountered when writing this example. In particular:
TlsListener
provides no way to access the underlying listener, meaning.local_addr()
has to be implemented by caching the address instead of calling a hypothetical.inner.listener().local_addr()
. This seems fairly easy to fix.tls_listener::AsyncAccept
is poll-based while axum’sListener
trait is async-based, it is not possible to easily bridge axum's existing error-handling logic with this crate; hence, I opted to simply copy-paste the code. Maybe it would be nice if axum exposedhandle_connection_error
in its public API.