Update toolbar_widget.dart#339
Open
PROGrand wants to merge 8 commits into
Open
Conversation
Owner
|
That makes sense, thanks! Is it possible that other string based colors could be added? Not sure - but what if the color is set as 'blue' or 'red' for example. |
|
@tneotia I think there is more work to be done on this front related to supporting additional colors, but at the same time merging this PR fixes an immediate issue. If we could merge this now and open a ticket for a future improvement for more color support I'd be happy to pick it up once I get more time. |
Fix deprecated code for Flutter 3.22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
int.parse(colorList[1]!, radix: 16)fails in some cases. For example:colorList[1] == 'transparent'.