fix(presto): transpile FROM_ISO8601_DATE to cast#7778
Merged
georgesittas merged 2 commits intoJun 22, 2026
Conversation
baruchoxman
changed the title
FROM_ISO8601_DATE is a Presto/Trino function parsing an ISO 8601 string into a date. It wasn't recognized as a dedicated expression, so it parsed as Anonymous and passed through unchanged to all dialects. Add a FromISO8601Date expression, transpile it to CAST(... AS DATE) in the base Generator, and keep the native function for Presto/Trino. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
baruchoxman
force-pushed
the
fix/from-iso8601-date-transpile
branch
from
3016c85 to
a381dfe
Compare
Contributor
Author
@georgesittas thanks for approving and merging! Any chance you could make a new release soon, that would include this ? |
Collaborator
|
There's no fixed released cadence, but we release often. Likely sometime this week. |
Collaborator
|
I just release v30.12.0, should be live within a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7777
FROM_ISO8601_DATEis a Presto/Trino function that parses an ISO 8601 string into a date. It wasn't recognized as a dedicated expression, so it parsed asAnonymousand passed through verbatim to every dialect:Change
exp.FromISO8601Dateexpression.CAST(... AS DATE)in the baseGenerator, so all dialects handle it (Snowflake, Spark, BigQuery, DuckDB, …).exp.FromISO8601Datetransform to the Presto generator so Presto/Trino keep emitting the native function.This mirrors the
from_iso8601_timestampfix in #7776.🤖 Generated with Claude Code