Skip to content

fix(presto): transpile FROM_ISO8601_DATE to cast #7778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 2 commits into from
Jun 22, 2026
+20 −0
Merged

fix(presto): transpile FROM_ISO8601_DATE to cast #7778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a381dfe
fix(presto): transpile FROM_ISO8601_DATE to cast [CLAUDE]
baruchoxman Jun 21, 2026
ae915a6
Merge branch 'main' into fix/from-iso8601-date-transpile
georgesittas Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sqlglot/expressions/temporal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,10 @@ class FromISO8601Timestamp(Expression, Func):
_sql_names = ["FROM_ISO8601_TIMESTAMP"]


class FromISO8601Date(Expression, Func):
_sql_names = ["FROM_ISO8601_DATE"]


class ParseDatetime(Expression, Func):
arg_types = {"this": True, "format": False, "zone": False, "default_year": False}

Expand Down
3 changes: 3 additions & 0 deletions sqlglot/generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3991,6 +3991,9 @@ def fromtimezone_sql(self, expression: exp.FromTimeZone) -> str:
zone = self.sql(expression, "zone")
return f"{this} AT TIME ZONE {zone} AT TIME ZONE 'UTC'"

def fromiso8601date_sql(self, expression: exp.FromISO8601Date) -> str:
return self.sql(exp.cast(expression.this, exp.DType.DATE))

def fromiso8601timestamp_sql(self, expression: exp.FromISO8601Timestamp) -> str:
return self.sql(exp.cast(expression.this, exp.DType.TIMESTAMPTZ))

Expand Down
1 change: 1 addition & 0 deletions sqlglot/generators/presto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ class PrestoGenerator(generator.Generator):
exp.Encode: lambda self, e: encode_decode_sql(self, e, "TO_UTF8"),
exp.FileFormatProperty: lambda self, e: f"format={self.sql(exp.Literal.string(e.name))}",
exp.First: _first_last_sql,
exp.FromISO8601Date: rename_func("FROM_ISO8601_DATE"),
exp.FromISO8601Timestamp: rename_func("FROM_ISO8601_TIMESTAMP"),
exp.FromTimeZone: lambda self, e: (
f"WITH_TIMEZONE({self.sql(e, 'this')}, {self.sql(e, 'zone')}) AT TIME ZONE 'UTC'"
Expand Down
12 changes: 12 additions & 0 deletions tests/dialects/test_presto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,18 @@ def test_cast(self):
"bigquery": "SELECT CAST('2020-05-11T11:15:05' AS TIMESTAMP)",
},
)
self.validate_all(
"SELECT FROM_ISO8601_DATE('2020-05-11')",
write={
"duckdb": "SELECT CAST('2020-05-11' AS DATE)",
"presto": "SELECT FROM_ISO8601_DATE('2020-05-11')",
"trino": "SELECT FROM_ISO8601_DATE('2020-05-11')",
"snowflake": "SELECT CAST('2020-05-11' AS DATE)",
"spark": "SELECT CAST('2020-05-11' AS DATE)",
"databricks": "SELECT CAST('2020-05-11' AS DATE)",
"bigquery": "SELECT CAST('2020-05-11' AS DATE)",
},
)
self.validate_all(
"CAST(x AS INTERVAL YEAR TO MONTH)",
write={
Expand Down
Loading