Skip to content

feat(optimizer)!: databricks type annotation for REGEXP_COUNT, REGEXP_EXTRACT_ALL#7797

Merged
geooo109 merged 4 commits into
mainfrom
type-inference-batch-1
Jun 26, 2026
Merged

feat(optimizer)!: databricks type annotation for REGEXP_COUNT, REGEXP_EXTRACT_ALL#7797
geooo109 merged 4 commits into
mainfrom
type-inference-batch-1

Conversation

@fivetran-amrutabhimsenayachit

@fivetran-amrutabhimsenayachit fivetran-amrutabhimsenayachit commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds Databricks type inference support for REGEXP_COUNT (INT) and REGEXP_EXTRACT_ALL (ARRAY), and fixture coverage for REGEXP, REGEXP_COUNT, and REGEXP_EXTRACT_ALL.

Tickets

  • RD-1229621 (ADD_MONTHS) — already complete via inheritance, no changes
  • RD-1229629 (REGEXP) — fixture entries only
  • RD-1229630 (REGEXP_COUNT) — new typing + fixture
  • RD-1229631 (REGEXP_EXTRACT) — already complete via inheritance, no changes
  • RD-1229632 (REGEXP_EXTRACT_ALL) — new typing + fixture

Test plan

  • make style — PASS
  • make unit — PASS

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

SQLGlot Integration Test Results

✅ All tests passed

Comparing:

  • this branch (sqlglot:type-inference-batch-1 @ sqlglot d2c8f9a)
  • baseline (main @ sqlglot 7a0a9ab)

Overall

main: 192428 total, 153523 passed (pass rate: 79.8%)

sqlglot:type-inference-batch-1: 180234 total, 142378 passed (pass rate: 79.0%)

Transitions:
No change

Dialect pair changes: 0 previous results not found, 3 current results not found

✅ All tests passed

Comment thread sqlglot/typing/databricks.py Outdated
Comment thread sqlglot/typing/databricks.py Outdated
@geooo109 geooo109 changed the title feat(typing): add databricks type inference module for REGEXP_COUNT, REGEXP_EXTRACT_ALL feat(optimizer)!: databricks type annotation for REGEXP_COUNT, REGEXP_EXTRACT_ALL Jun 26, 2026
@geooo109 geooo109 merged commit 58f5bf9 into main Jun 26, 2026
8 of 9 checks passed
@geooo109 geooo109 deleted the type-inference-batch-1 branch June 26, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants