fix(settings): reliably show session replay ID#3843
Conversation
Co-authored-by: Jan Six <six.jan@gmail.com>
Co-authored-by: Jan Six <six.jan@gmail.com>
|
|
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 18 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
|
Commit SHA:82c3abc9c67229c4d9c89922496e4537ac62aa25 Test coverage results 🧪
|
|
Commit SHA:82c3abc9c67229c4d9c89922496e4537ac62aa25 |
Why does this PR exist?
Closes #3271
Session recording can be toggled on, but the replay/session ID is often still unavailable on the first immediate lookup. That leaves the Settings UI without the ID users need to share for debugging.
What does this pull request do?
getReplaySessionIdWithRetry()insrc/app/components/Settings/.Settingswhen:start()throws.Testing this change
yarn test src/app/components/Settings/getReplaySessionIdWithRetry.test.ts --runInBandnpx eslint src/app/components/Settings/getReplaySessionIdWithRetry.ts src/app/components/Settings/getReplaySessionIdWithRetry.test.tsAdditional Notes (if any)
This is intentionally scoped to ID retrieval robustness and does not change Sentry replay initialization semantics outside the Settings interaction path.