New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_array method to Buf #781

Open

lperlaki wants to merge 2 commits into tokio-rs:master from lperlaki:get-array

+84 −28

lperlaki commented Mar 24, 2025

This would increase the MSRV to 1.51 since it uses const generics!

I am not sure on the MSRV policy of bytes, so if this is a problem we can just close this PR

Added Methods

Buf::try_get_array
is a copy of the old implementation of buf_try_get_impl
Buf::get_array simply calls try_get_array and panic_advance on error

the second commit changes the implementation of the get_x methods to use try_get_array

this would also enable Buf implementors to optimise (like #622) the get_x methods by overriding try_get_array

lperlaki added 2 commits

March 24, 2025 13:48


          add get_array to Buf

f54e65e


          implement buf_try_get_impl with try_get_array

79e06c6

lperlaki force-pushed the get-array branch from ca78d85 to 79e06c6 Compare

March 24, 2025 12:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet