Security: fix 23 vulnerabilities from V12 audit#122
Merged
Conversation
Fixed high-severity issues: - Encoder recursion without cycle guards (StackOverflowError DoS) - Quadratic algorithm in ListItemEncoder - Malformed options crash encoding (null delimiter, negative indent) Fixed medium-severity issues: - Options validation (indent bounds, null checks) - Stream input bounds (max 10000 elements) - Numeric string type preservation (+1, .5, -.5, 1.) - BigDecimal precision loss - Invalid escape sequences (now throw instead of lossy) - Key folding aliasing and prefix collision - Duplicate tabular headers - Nested array length mismatch Added depth limits: - MAX_DEPTH=512 for normalization - MAX_ENCODE_DEPTH=1024 for encoding - MAX_DECODE_DEPTH=1024 for decoding - MAX_INDENT=100 for options - MAX_STREAM_ELEMENTS=10000 Security fixes applied to: - EncodeOptions/DecodeOptions validation - JsonNormalizer (cycle detection, depth limits) - ValueEncoder/ObjectEncoder/ArrayEncoder/ListItemEncoder - ValueDecoder/ObjectDecoder/TabularArrayDecoder - StringEscaper/StringValidator - Flatten (key folding collision detection)
security: fix 23 vulnerabilities from V12 audit
Contributor
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #
Description
Type of Change
Changes Made
SPEC Compliance
Testing
Pre-submission Checklist
Breaking Changes
Additional Context