Update op precision for opFuncs#8
Merged
Merged
Conversation
viji560
requested changes
May 5, 2026
Contributor
viji560
left a comment
viji560
left a comment
There was a problem hiding this comment.
@vswagath1989 -- Minor nit-pick
Line 273 should be "FP32TODL16" - not "DL16TOFP32 "
Do we have to add any comment in the document about leaving certain auxiliary operations in DL16 only (i.e., not having FP32 version for them)?
Contributor
|
Testing fp32 LayerNorm through torch-spyre stack.. will approve/merge after verification. |
mudhakar
approved these changes
May 15, 2026
Signed-off-by: Swagath Venkataramani <swagath.venkataramani@ibm.com>
Signed-off-by: Swagath Venkataramani <swagath.venkataramani@ibm.com>
fixed typo (fp32todl16) Signed-off-by: Swagath Venkataramani <swagath.venkataramani@ibm.com>
vswagath1989
force-pushed
the
sdsc_bundle_spec_update
branch
from
55695d5 to
191a22b
Compare
viji560
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update operation precision for each opFuncs