R1-213: Template code audit

rca/home/utils.py

@@ -4,6 +4,9 @@
 def related_news_events_formatter(
     page, long_description=False, editorial_meta_label=""
 ):
+    if not page:
+        return {}
+
     # Organsises data into a digestable format for the template.
     editorial_meta = editorial_meta_label
     PAGE_META_MAPPING = {
@@ -55,6 +58,9 @@ def partnerships_slides_formatter(slides):
                 }
             )
         elif slide.block_type == "page":
+            if not slide.value:
+                continue
+
             page_type = None
             page_type_mapping = {
                 "GuidePage": "GUIDE",

rca/landingpages/models.py

@@ -448,6 +448,8 @@ def get_page_list(self):
                     }
                     item["related_items"].append(page)
                 if page_block.block_type == "page":
+                    if not page_block.value:
+                        continue
                     item["related_items"].append(page_block.value.specific)
             items.append(item)
         return items
@@ -461,6 +463,9 @@ def _format_slideshow_pages(self, slideshow_pages):
         # The template is formatted to work with blocks, so we need to match the
         # data structure to now work with pages chooser values
         for slide in slideshow_pages.all():
+            if not slide.page:
+                continue
+
             page = slide.page.specific
             if not page.live:
                 continue
@@ -836,7 +841,11 @@ def featured_events(self):
 
     def get_stories(self):
         pages = self.related_editorial_story_pages.all().select_related("page")
-        return [editorial_teaser_formatter(page.page.specific) for page in pages]
+        return [
+            editorial_teaser_formatter(page.page.specific)
+            for page in pages
+            if page.page
+        ]
 
     @property
     def news_view_all(self):

rca/utils/formatters.py

@@ -28,6 +28,9 @@ def related_list_block_slideshow(slides):
                     }
                 )
             elif block.block_type == "page":
+                if not block.value:
+                    continue
+
                 page = block.value.specific
                 page_type = page_type_mapping.get(page.__class__.__name__, None)
                 summary = (
@@ -71,6 +74,9 @@ def format_page_teasers(obj):
                     }
                 )
             elif block.block_type == "page":
+                if not block.value:
+                    continue
+
                 page = block.value.specific
                 summary = (
                     page.introduction