R1-268: Scholarships - Ordering and labels #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilbulloch
reviewed
Oct 31, 2025
neilbulloch
reviewed
Oct 31, 2025
Collaborator
There was a problem hiding this comment.
Suggestion: Avoid using autogenerated migration names :)
neilbulloch
reviewed
Oct 31, 2025
rca/project_styleguide/templates/patterns/pages/scholarships/scholarships_listing_page.html
Outdated
Show resolved
Hide resolved
neilbulloch
reviewed
Oct 31, 2025
rca/project_styleguide/templates/patterns/pages/scholarships/scholarships_listing_page.html
Outdated
Show resolved
Hide resolved
neilbulloch
requested changes
Oct 31, 2025
Collaborator
neilbulloch
left a comment
neilbulloch
left a comment
There was a problem hiding this comment.
Thanks @patrickcuagan looks nice, just a couple of things :)
added 3 commits
November 3, 2025 09:14
…ature/268-scholarships-ordering-and-labels
patrickcuagan
deleted the
feature/268-scholarships-ordering-and-labels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://torchbox.atlassian.net/browse/R1-268
This MR moves the scholarships filters section to be below the title in the scholarships listing page. Additionally, editors can choose its background color.
As for the filter label, we just add a simple rename to be 'Fee status' as requested.