Wagtail 7.1 maintenance #39
Conversation
tests/test_image_chooser_views.py
Outdated
| create_object_mock.assert_called_once() | ||
| self.assertEqual(response.status_code, 200) | ||
| response_json = response.json() | ||
| self.assertEqual(response_json["step"], "chosen") |
There was a problem hiding this comment.
question: why not leave the full dict?
There was a problem hiding this comment.
No reason why I can't, cursor suggested the code change and I liked the suggestion. Do you prefer it the dict way? Happy to change it.
There was a problem hiding this comment.
Let's keept it at full dict. Fewer surprises.
There was a problem hiding this comment.
I found that we needed to consider dict differences between 6.3 and 7.0 so there's a little more work here: 78d89dd
This reverts commit 5df2748.
…sed on Wagtail version. Technically this is a wagtail 6.4+ compatibility fix. But as 6.4 isn't a supported or tested version then 7.0+ is OK.
|
I realised that So the import here https://github.com/torchbox/wagtail-bynder/blob/main/src/wagtail_bynder/widgets.py#L7 will need to be updated. This may or may not need a conditional import but I think not. |
2 participants
This pull request updates the project to support newer versions of Python, Django, and Wagtail, and refactors several views and migrations for improved compatibility and maintainability.
Dependency and compatibility updates:
.github/workflows/test.ymlandpyproject.tomlto Python 3.13, Django 5.2, and Wagtail 7.x, and adjusted test matrix accordingly.View refactoring for Wagtail version support:
src/wagtail_bynder/views/document.pyandsrc/wagtail_bynder/views/image.pyto remove legacy support for Wagtail <6.3Testing improvements:
tests/test_image_chooser_views.pyMigration and model restructuring:
tests/testapp/migrations/0001_initial.pyOne could consider #37 to be not required and #38 to be included.