fix(compat/trim): trim should support character arrays (#821)

* fix(compat/pad): pad should support character arrays * Update src/compat/string/trim.ts * Update src/compat/string/trim.ts * fix --------- Co-authored-by: Sojin Park <[email protected]>
toss · Nov 13, 2024 · ba84918 · ba84918
1 parent 0aa9dc2
commit ba84918
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 3 deletions.
diff --git a/src/compat/string/trim.spec.ts b/src/compat/string/trim.spec.ts
@@ -72,4 +72,14 @@ describe('trim', () => {
 
     expect(actual).toEqual([trimmed, trimmed, trimmed]);
   });
+
+  it(`\`trim\` should support character arrays`, () => {
+    const string = 'hello world';
+    const expected = 'o wo';
+
+    expect(func(string, ['rld', 'hel'])).toBe(expected);
+    expect(func(string, ['rl', 'd', 'he', 'l'])).toBe(expected);
+    expect(func(string, ['he', 'd', 'lr'])).toBe(expected);
+    expect(func(string, ['d', 'l', 'r', 'e', 'h'])).toBe(expected);
+  });
 });
diff --git a/src/compat/string/trim.ts b/src/compat/string/trim.ts
@@ -29,7 +29,7 @@ export function trim(str: string, chars?: string | string[], guard?: unknown): s
       if (Array.isArray(chars)) {
         return trimToolkit(
           str,
-          chars.map(x => x.toString())
+          chars.flatMap(x => x.toString().split(''))
         );
       } else {
         return trimToolkit(str, (chars as any).toString().split(''));

diff --git a/src/compat/string/trimEnd.spec.ts b/src/compat/string/trimEnd.spec.ts
@@ -72,4 +72,14 @@ describe('trimEnd', () => {
 
     expect(actual).toEqual([trimmed, trimmed, trimmed]);
   });
+
+  it(`\`trimEnd\` should support character arrays`, () => {
+    const string = 'hello world';
+    const expected = 'hello wo';
+
+    expect(func(string, ['rld'])).toBe(expected);
+    expect(func(string, ['rl', 'd'])).toBe(expected);
+    expect(func(string, ['d', 'lr'])).toBe(expected);
+    expect(func(string, ['d', 'l', 'r'])).toBe(expected);
+  });
 });
diff --git a/src/compat/string/trimEnd.ts b/src/compat/string/trimEnd.ts
@@ -30,7 +30,7 @@ export function trimEnd(str: string, chars?: string | string[], guard?: unknown)
       if (Array.isArray(chars)) {
         return trimEndToolkit(
           str,
-          chars.map(x => x.toString())
+          chars.flatMap(x => x.toString().split(''))
         );
       } else {
         return trimEndToolkit(str, (chars as any).toString().split(''));

diff --git a/src/compat/string/trimStart.spec.ts b/src/compat/string/trimStart.spec.ts
@@ -71,4 +71,14 @@ describe('trimStart', () => {
 
     expect(actual).toEqual([trimmed, trimmed, trimmed]);
   });
+
+  it(`\`trimStart\` should support character arrays`, () => {
+    const string = 'hello world';
+    const expected = 'o world';
+
+    expect(func(string, ['hel'])).toBe(expected);
+    expect(func(string, ['he', 'l'])).toBe(expected);
+    expect(func(string, ['eh', 'l'])).toBe(expected);
+    expect(func(string, ['l', 'e', 'h'])).toBe(expected);
+  });
 });
diff --git a/src/compat/string/trimStart.ts b/src/compat/string/trimStart.ts
@@ -30,7 +30,7 @@ export function trimStart(str: string, chars?: string | string[], guard?: unknow
       if (Array.isArray(chars)) {
         return trimStartToolkit(
           str,
-          chars.map(x => x.toString())
+          chars.flatMap(x => x.toString().split(''))
         );
       } else {
         return trimStartToolkit(str, (chars as any).toString().split(''));