Skip to content

docs: replace image with copyable code block in submit-button.md #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

umsungjun
Copy link
Contributor

@umsungjun umsungjun commented Apr 9, 2025

๐Ÿ“ Key Changes

  • ๊ธฐ์กด ์ด๋ฏธ์ง€ ๊ธฐ๋ฐ˜ ์˜ˆ์‹œ๋ฅผ ๋ณต์‚ฌ ๊ฐ€๋Šฅํ•œ ์ฝ”๋“œ ๋ธ”๋ก์œผ๋กœ ๋ณ€๊ฒฝํ•˜์—ฌ ๋ฌธ์„œ์˜ ๊ฐ€๋…์„ฑ๊ณผ ํ†ต์ผ์„ฑ์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ฝ”๋“œ์˜ ์‹ค์ œ ํ๋ฆ„์— ๋งž๊ฒŒ ์„ค๋ช… ๋ฌธ๊ตฌ๋ฅผ ๊ฐ„๊ฒฐํ•˜๊ณ  ์‰ฝ๊ฒŒ ์ดํ•ดํ•  ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ฝ”๋“œ ๋ณต์‚ฌ ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ•˜์—ฌ ๋ฌธ์„œ ํ™œ์šฉ๋„๋ฅผ ๋†’์˜€์Šต๋‹ˆ๋‹ค.
  • ๋งŒ์•ฝ ์ด Pull Request๊ฐ€ ๋จธ์ง€๋œ๋‹ค๋ฉด, ๋ฌธ์„œ์˜ ์˜์–ด, ์ผ๋ณธ์–ด, ์ค‘๊ตญ์–ด ๋ฒˆ์—ญ ์ž‘์—…๋„ ์ง„ํ–‰ํ•ด ์ฃผ์‹ค ์ˆ˜ ์žˆ๋Š”์ง€ ํ™•์ธ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

English

  • Replaced the image-based example with a copyable code block to improve the readability and consistency of the documentation.
  • Updated the explanatory text to be concise and easy to understand, aligning it with the actual code flow.
  • Added a code copying feature to enhance the usability of the documentation.
  • If this Pull Request is merged, please confirm whether you can also proceed with translating the documentation into English, Japanese, and Chinese.

๐Ÿ–ผ๏ธ Before and After Comparison

Before
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-04-09 แ„‹แ…ฉแ„’แ…ฎ 8 53 53

After
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-04-09 แ„‹แ…ฉแ„’แ…ฎ 8 55 34

- ๊ธฐ์กด ์ด๋ฏธ์ง€ ๊ธฐ๋ฐ˜ ์˜ˆ์ œ ์ฝ”๋“œ๋ฅผ ์ฝ”๋“œ ๋ธ”๋ก์œผ๋กœ ๋Œ€์ฒดํ•˜์—ฌ ํ†ต์ผ์„ฑ ๋ฐ ๊ฐ€๋…์„ฑ ํ–ฅ์ƒ
- ์ด๋ฏธ์ง€ ํ™”์งˆ ์ €ํ•˜ ๋ฐ ๋ฌธ์„œ ์Šคํƒ€์ผ๊ณผ์˜ ์ด์งˆ๊ฐ ํ•ด์†Œ
- ์ฝ”๋“œ ๋ณต์‚ฌ ๊ธฐ๋Šฅ ์ง€์›์œผ๋กœ ๋ฌธ์„œ ํ™œ์šฉ๋„ ์ฆ๊ฐ€
- ์„ค๋ช… ๋ฌธ๊ตฌ๋ฅผ ๊ฐ„๊ฒฐํ•˜๊ณ  ์‰ฝ๊ฒŒ ์ดํ•ดํ•  ์ˆ˜ ์žˆ๋„๋ก ๊ฐœ์„ 
Copy link

vercel bot commented Apr 9, 2025

@umsungjun is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@milooy milooy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ๐Ÿ‘๐Ÿ‘๐Ÿ‘๐Ÿ‘

๋งŒ์•ฝ ์ด Pull Request๊ฐ€ ๋จธ์ง€๋œ๋‹ค๋ฉด, ๋ฌธ์„œ์˜ ์˜์–ด, ์ผ๋ณธ์–ด, ์ค‘๊ตญ์–ด ๋ฒˆ์—ญ ์ž‘์—…๋„ ์ง„ํ–‰ํ•ด ์ฃผ์‹ค ์ˆ˜ ์žˆ๋Š”์ง€ ํ™•์ธ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.
For this thing, I want you to update text from English, Japanese, and Chinese also. (by transition app!)

Just a quick note on our contribution rules:

  • Korean and English docs should go through a review before being updated.
  • Chinese and Japanese translations can be added in the same PR using a translation tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants