Skip to content

ci(.github/workflows/release): add 'publish' option to 'changesets/action' for GitHub Release creation#336

Open
sukvvon wants to merge 1 commit intotoss:mainfrom
sukvvon:ci/release-add-publish-option
Open

ci(.github/workflows/release): add 'publish' option to 'changesets/action' for GitHub Release creation#336
sukvvon wants to merge 1 commit intotoss:mainfrom
sukvvon:ci/release-add-publish-option

Conversation

@sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Mar 6, 2026

Overview

Add publish option to changesets/action to enable automatic GitHub Release creation on publish.

Previously, npm publish was handled in a separate step, which created tags but did not generate GitHub Releases. By moving the publish command into changesets/action, it now automatically creates GitHub Releases after publishing.

Reference: toss/suspensive release workflow

Checklist

  • Did you write the test code?
  • Have you run yarn run fix to format and lint the code and docs?
  • Have you run yarn run test:coverage to make sure there is no uncovered line?
  • Did you write the JSDoc?

@kimyouknow
Copy link
Collaborator

Thank you for the contribution!

Unfortunately, we need to reject this change. Adding the publish option to changesets/action would break our OIDC-based npm publishing:

  • changesets/action with publish option overwrites .npmrc, which breaks the OIDC token configuration
  • Our current setup uses GitHub Actions OIDC (Trusted Publishing) — no secret tokens needed
  • The publish step must remain separate from changesets/action to preserve the OIDC .npmrc

See npm/cli#7586 for related context on npm publishing constraints.

Closing this PR to protect the release pipeline. Thank you for your understanding!

@kimyouknow kimyouknow closed this Mar 17, 2026
@kimyouknow kimyouknow reopened this Mar 17, 2026
@kimyouknow
Copy link
Collaborator

Apologies for closing this right away — I should have given you time to respond.

I understand the intent here: having GitHub Releases created automatically would be a nice improvement. The concern is specifically about the publish option in changesets/action overwriting .npmrc, which breaks our OIDC setup.

If you have ideas on how to achieve automatic GitHub Release creation without interfering with the OIDC publishing flow (e.g., a separate workflow step or action), I'd be happy to explore that. Reopening for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants