Skip to content

[#161465877] hide buy/sell button in the equity portfolio if the acco… #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[#161465877] hide buy/sell button in the equity portfolio if the acco… #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33cdd97
[#161465877] hide buy/sell button in the equity portfolio if the acco…
guillaumedebavelaere Nov 5, 2018
86f2824
Disable swipe to trade when no order capabilities
guillaumedebavelaere Dec 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions TradeItIosTicketSDK2/TradeItPortfolioAccountDetailsTableViewManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ class TradeItPortfolioAccountDetailsTableViewManager: NSObject, UITableViewDeleg
func tableView(_ tableView: UITableView, canEditRowAt indexPath: IndexPath) -> Bool {
return indexPath.section == SECTIONS.positions.rawValue &&
self.positions?[safe: indexPath.row]?.position?.instrumentType() == .EQUITY_OR_ETF &&
self.positions?[safe: indexPath.row]?.linkedBrokerAccount.orderCapabilities(forInstrument: TradeItTradeInstrumentType.equities) != nil &&
self.selectedPositionIndex != indexPath.row
}

Expand Down
6 changes: 6 additions & 0 deletions TradeItIosTicketSDK2/TradeItPortfolioEquityPositionsTableViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ class TradeItPortfolioEquityPositionsTableViewCell: UITableViewCell {
// MARK: private

private func updateTradeButtonVisibility() {
guard let _ = self.selectedPosition?.linkedBrokerAccount.orderCapabilities(forInstrument: TradeItTradeInstrumentType.equities) else {
Copy link
Contributor Author

@guillaumedebavelaere guillaumedebavelaere Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a tradeable flag in the account response we don't have in the TradeItLinkedBrokerAccount. Should we add and use this flag instead of checking the capabilities?

self.buyButton.isHidden = true
self.sellButton.isHidden = true
return
}

if self.selectedPosition?.position?.instrumentType() == TradeItPositionInstrumentType.EQUITY_OR_ETF {
self.buyButton.isHidden = false
self.sellButton.isHidden = false
Expand Down