[pull] master from golang:master#34
Merged
Merged
Conversation
…nput Document that image.Decode may allocate memory proportional to width and height from the image header before all pixel data is consumed or validated, and that image.DecodeConfig reads only headers without allocating a full pixel buffer. Add package-level and function-level notes on gif.Decode, gif.DecodeAll, and gif.DecodeConfig pointing to the same guidance and the Security Considerations section in package image. Add ExampleDecode_untrusted in package image: call DecodeConfig, reject oversized dimensions using an int64 pixel product, then Decode. Updates #79063 Change-Id: I491fa036dab49f4d413e04df161da5f430f3cf97 GitHub-Last-Rev: 8effaee GitHub-Pull-Request: #79221 Reviewed-on: https://go-review.googlesource.com/c/go/+/774640 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Alan Donovan <adonovan@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
386 and AMD64's splitload could silently change a pointer type to an int type. Fix that. Add type preservation to the narrower widths for symmetry, even though it doesn't matter in the same way there. Change-Id: I155d136dd43989900d26f2a7f014d7300fdbb7cb Reviewed-on: https://go-review.googlesource.com/c/go/+/777820 Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Keith Randall <khr@google.com> Auto-Submit: Keith Randall <khr@golang.org>
For #78737 Change-Id: Ie8468fcdf6f7fa8e89522eaa0e7ba2636a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/777921 Auto-Submit: Nicholas Husin <husin@google.com> Reviewed-by: Nicholas Husin <husin@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )