feat: add Code Quality finding type with comment-on-issue workflow#159
Open
feat: add Code Quality finding type with comment-on-issue workflow#159
Conversation
Code Quality is a new value in the FindingType enum. When a finding has type "Code Quality", the details panel hides severity, difficulty, exploit scenario, and recommendation fields. The "Open Remote Issue" flow posts a comment on a single designated GitHub issue instead of creating a new issue per finding. The CQ issue number is stored per-workspace-root, shared across sibling roots with the same audit repo, and editable from both the command palette and the Repository Configuration panel. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fcasal
requested changes
Feb 24, 2026
|
|
||
| // If no CQ issue number is set, prompt the user | ||
| if (wsRoot.codeQualityIssueNumber === undefined) { | ||
| const choice = await vscode.window.showQuickPick(["Enter existing issue number", "Create a new issue"], { |
Collaborator
There was a problem hiding this comment.
Should have a title and probably ignoreFocusOut = true to prevent panel closing when the user is looking around for the issue number. Same for the other new quickpick menus
|
|
||
| if (!skipConfirmation) { | ||
| // Prompt the user before copying and opening, consistent with the too-long-URL fallback in openGithubIssue | ||
| const action = await vscode.window.showInformationMessage( |
Collaborator
There was a problem hiding this comment.
This box should have a button that opens the correct setting
Member
Author
There was a problem hiding this comment.
Done. Also explains why the button is there.
- Add title and ignoreFocusOut to CQ QuickPick menus for consistency - Add "Open Settings" button to CQ confirmation dialog - Move CodeQuality from FindingType to FindingSeverity so selecting it in the first dropdown naturally hides subsequent fields Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fcasal
reviewed
Mar 4, 2026
src/codeMarker.ts
Outdated
| } | ||
|
|
||
| await vscode.env.clipboard.writeText(commentBody); | ||
| const issuePageUrl = `${wsRoot.gitRemote}/issues/${wsRoot.codeQualityIssueNumber}#sr-footer-heading`; |
Collaborator
There was a problem hiding this comment.
I'm guessing this will only work on GitHub?
Member
Author
There was a problem hiding this comment.
GitLab support added and tested (once)
…prompt Move Code Quality before Informational in the severity dropdown and add explanatory text to the confirmation dialog so users understand why the Settings button is there. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… support The "Create a new issue" path fell through into the "Enter existing issue number" input, causing two consecutive prompts. Wrapping the second path in an `else` clause fixes this. Also adds GitLab issue URL support (using /-/issues/ path format) alongside the existing GitHub URL handling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Nice, I like the workflow. Note that the description above states
But the "Code Quality" drop down option is actually under severity, not type. |
Member
Author
|
Yeah, that was one of the changes Filipe requested. It originally was under Type but Severity makes more sense! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Quality is a new value in the FindingType enum. When a finding has
typeseverity "Code Quality", the details panel hidesseveritytype, difficulty, exploit scenario, and recommendation fields. The "Open Remote Issue" flow posts a comment on a single designated GitHub issue instead of creating a new issue per finding. The CQ issue number is stored per-workspace-root, shared across sibling roots with the same audit repo, and editable from both the command palette and the Repository Configuration panel.Implements #156