Lint PR Commit style - #757
Merged
Merged
Conversation
This way, we can ensure that merging will be made harder if commit style is not satisfied. With this, we can also disallow extra commits like merges for the PR merge. re tramhao#708
hasezoey
marked this pull request as draft
August 15, 2026 13:56
hasezoey
marked this pull request as ready for review
August 15, 2026 13:57
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds
committedas our commit linter.For now this will only run in the CI for a PR.
This helps us enforce our CONTRIBUTING Commit message style and allows quick feedback without having to wait for a review (which might even miss this).
As a aside, adds a missing
perftype for the commit messages.re #708
Works in conjunction with #754
closes #758 (showcase PR)