Enable cookie store at request level #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient#1571 Motivation: Sending a chunked request body (hence not direct) cause AHC to crash. Motivation: Fix SslHandler position that should be before the ChunkedWriteHandler. Result: Chunked request works with HTTPS proxy.
…ent#1585), close AsyncHttpClient#1568 * Add non-null ResponseBody for responses with empty body * Introduced empty ResponseBody as a constant
…r instance String) as the key type (AsyncHttpClient#1587)
…HttpClient#1582) * add the ability to pass in a {principal name, keytab} combination to async http client. * fix issue where spnego principal/keytab was no longer optional * specify the login config as a map to allow all the values custom not just a couple of them. * remove the principal/password assertion on not null add a map of spnego engines so you can support more than one spnego login confg per jvm * no need to detect null on loginContext * add a SpnegoEngine unit test. * Delete kerberos.jaas * Update pom.xml * Provide more granularity to be more aligned with other http clients: * Login context name * Username/password auth option * remove useless comment * add login context name and username into the instance key * cxf.kerby.version -> kerby.version
…lName is not specified. (AsyncHttpClient#1588) * fix when servicePrincipalName is not specified. * unit test the fix.
Thanks a lo, it really helps!
* Added BlockingConnectionSemaphoreFactory * Added missing copyright to BlockingSemaphoreInfinite * Added acquireFreeChannelTimeout configuration value * Implemented acquireFreeChannelTimeout by replacing existing NonBlocking semaphores with regular Semaphores * ConnectionSemaphore tests
Fixed artifact name to `async-http-client-extras-typesafe-config`, there was a missing dash
Motivation: We don't set SO_KEEPALIVE on the socket. Modification: Enable SO_KEEPALIVE by default and introduce org.asynchttpclient.soKeepAlive config option to disable it. Result: SO_KEEPALIVE supported
performRelease is set by release:perform
Addresses the issue described in netty/netty#10111
…ent#1714 Motivation: Setting CookieStore to null in conf should be supported to disable it. Latest commit introduced a NPE regression. Modification: * Protect against null CookieStore * Make sure to decrement CookieStore ref count when AHC instance is closed. Result: No more NPE when CookieStore is null.
… into feature/enable-cookie-store-at-request-level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To enable the ability to pass CookieStore at request level.