Repository navigation
Conversation
parse_ordered_list_marker() passed lexer->lookahead (a full Unicode codepoint, e.g. 8211 for an en dash) directly to isdigit(). On the Windows debug CRT this trips the assertion 'c >= -1 && c <= 255' in isctype.cpp, crashing any consumer that parses markdown containing non-ASCII characters. CommonMark ordered-list markers are ASCII digits 0-9 only, which is also exactly what isdigit() matches in the C locale, so replace the isdigit() calls with a direct '0'..'9' range check. This preserves grammar behavior while removing the locale/ctype dependency and the out-of-range codepoint crash.
Collaborator
|
Thank you, but this is really an upstream issue (improper use of locales) that needs to be solved there. See tree-sitter/tree-sitter#5255 |
Author
|
Ah okay, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_ordered_list_marker() passed lexer->lookahead (a full Unicode codepoint, e.g. 8211 for an en dash) directly to isdigit(). On the Windows debug CRT this trips the assertion 'c >= -1 && c <= 255' in isctype.cpp, crashing any consumer that parses markdown containing non-ASCII characters.
CommonMark ordered-list markers are ASCII digits 0-9 only, which is also exactly what isdigit() matches in the C locale, so replace the isdigit() calls with a direct '0'..'9' range check. This preserves grammar behavior while removing the locale/ctype dependency and the out-of-range codepoint crash.