Repository navigation
feat: Add 'pending' state to 'task_list_marker' - #254
Closed
riodelphino wants to merge 1 commit into
Closed
riodelphino wants to merge 1 commit into
riodelphino wants to merge 1 commit into
Conversation
Collaborator
|
I don't think this is part of the specification that this parser targets, so out of scope. |
Author
|
I got it. I'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some Neovim plugins treat
[-]as a "pending" task state, but tree-sitter-markdown currently has no dedicated marker for it. As a result,[-]falls through to regular paragraph text and gets parsed by the inline grammar as a shortcut link — which then gets concealed by highlight/conceal queries that hide link syntax.This PR adds a
task_list_marker_pendingnode (mirroring the existingtask_list_marker_checked/task_list_marker_unchecked), so[-]is recognized as a task list marker instead of link syntax, and stays visible.A test for the pending state was added to
extension_task_list.txt.Replaces #182
This replaces my own #182 from ~2 years ago. That branch had gone stale relative to
split_parserand could no longer be merged cleanly. This PR is rebuilt from scratch against the currentsplit_parserHEAD.The full test suite passing locally.