Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish package with GitHub Actions #138

Closed
wants to merge 2 commits into from

Conversation

verhovsky
Copy link
Collaborator

No description provided.

@skovhus
Copy link
Contributor

skovhus commented Dec 14, 2022

This would be great @maxbrunsfeld and help solve #134

@skovhus
Copy link
Contributor

skovhus commented Feb 1, 2023

@verhovsky should this be merged? This would be great.

@verhovsky
Copy link
Collaborator Author

verhovsky commented Feb 2, 2023

@skovhus as far as I know, @maxbrunsfeld is the only one who can make releases. If this is merged it won't work until/unless he adds an npm API key and github API key. It is up to him if he wants this/if this will help him.

@verhovsky

This comment was marked as off-topic.

@verhovsky
Copy link
Collaborator Author

verhovsky commented May 5, 2023

5 months later, I am older and wiser and understand a bit more about what prebuild is and how to work with binaries with Node. I updated this PR to also prebuild the binaries through github actions and used these changes in my fork of tree-sitter-bash to publish v0.0.3 and prebuild it for Node on windows/mac/linux

https://github.com/curlconverter/tree-sitter-bash/actions/runs/4889743355/jobs/8728583727

I didn't try publishing a Rust crate for my fork but it should work.

@amaanq amaanq closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants