Skip to content

feat: add range select component#277

Merged
ClaraTschamon merged 1 commit intomainfrom
feature/pina-8332-add-range-select
Feb 12, 2026
Merged

feat: add range select component#277
ClaraTschamon merged 1 commit intomainfrom
feature/pina-8332-add-range-select

Conversation

@ClaraTschamon
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boemly Ready Ready Preview, Comment Feb 12, 2026 7:10am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 11, 2026

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/index.js 226.19 KB (-0.01% 🔽) 4.6 s (-0.01% 🔽) 258 ms (-22.67% 🔽) 4.8 s
dist/index.cjs 324.61 KB (+0.21% 🔺) 6.5 s (+0.21% 🔺) 4.2 s (-0.26% 🔽) 10.7 s

@ClaraTschamon ClaraTschamon force-pushed the feature/pina-8332-add-range-select branch 2 times, most recently from e06a1d6 to 6c412b5 Compare February 11, 2026 12:50
@ClaraTschamon ClaraTschamon force-pushed the feature/pina-8332-add-range-select branch from 6c412b5 to 42ece5f Compare February 11, 2026 13:03
@ClaraTschamon
Copy link
Contributor Author

Also fixed the "with selected value" story

Copy link
Member

@lukasbals lukasbals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to be so annoying - but this IMO doesn't fit into the select component. I would make this it's own component to keep the Select cleaner .... if we add properties like rangeFromLabel, ... it really doesn't make sense to have this as a variant of the select. Do you agree?

Comment on lines 139 to 141
const [value, setValue] = React.useState<string[]>(['', '']);
const [fromError, setFromError] = React.useState<string>('');
const [toError, setToError] = React.useState<string>('');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const [value, setValue] = React.useState<string[]>(['', '']);
const [fromError, setFromError] = React.useState<string>('');
const [toError, setToError] = React.useState<string>('');
const [value, setValue] = useState<string[]>(['', '']);
const [fromError, setFromError] = useState<string>('');
const [toError, setToError] = useState<string>('');

Usually we import useState directly ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the "with selected value" variant.

@@ -0,0 +1,246 @@
'use client';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?
Does it make sense to have it if it's not Next.js app? (Boemly is no Next.js app)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use client' is a react directive

We need it in this component because with hooks we can't use SSR.

Chakra-UI documentation:
https://chakra-ui.com/docs/components/concepts/server-components

@ClaraTschamon ClaraTschamon force-pushed the feature/pina-8332-add-range-select branch from 3372e0a to 42f6d49 Compare February 12, 2026 07:09
@ClaraTschamon ClaraTschamon changed the title feat: add range select variant feat: add range select component Feb 12, 2026
@ClaraTschamon ClaraTschamon merged commit 7d289d1 into main Feb 12, 2026
8 checks passed
@ClaraTschamon ClaraTschamon deleted the feature/pina-8332-add-range-select branch February 12, 2026 07:19
@github-actions
Copy link

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants