Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana loadable tokens definitions & rent fee #4638

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

arjaz
Copy link

@arjaz arjaz commented Feb 17, 2025

Includes a fix for the token_mint display_name, loadable tokens definitions and the rent fee information for Solana.

@arjaz arjaz requested a review from matejcik as a code owner February 17, 2025 08:55
@arjaz arjaz force-pushed the solana-token-definitions-merge-branch branch from 5c1503d to ec1c912 Compare February 17, 2025 13:31
Comment on lines +117 to +124
account_description = f"{base58.encode(account_value[0])}"
if account_template.is_token_mint and definitions:
token = definitions.get_token(account_value[0])
account_description = f"{token.ticker}\n{account_description}"
elif account_value[0] == signer_public_key:
account_description = f"{account_description} ({TR.words__signer})"

account_data.append((ui_property.display_name, account_description))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should be the UI here?

@arjaz arjaz requested a review from prusnak as a code owner February 19, 2025 08:01
@arjaz arjaz changed the title Solana loadable tokens definitions Solana loadable tokens definitions & rent fee Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant