Add last_result_size to ruby connection#190
Closed
EvilGenius13 wants to merge 1 commit intotrilogy-libraries:mainfrom
Closed
Add last_result_size to ruby connection#190EvilGenius13 wants to merge 1 commit intotrilogy-libraries:mainfrom
last_result_size to ruby connection#190EvilGenius13 wants to merge 1 commit intotrilogy-libraries:mainfrom
Conversation
Add a new method `last_result_size` to the Trilogy gem's Ruby bindings that allows users to retrieve the exact byte size of the last result received from a query.
Collaborator
|
Thanks for the PR. Could you say more about what the motivation is for this? I think (though I'm not 100% sure) that looking at |
Collaborator
|
I think |
|
We're trying to instrument the amount of data received over the network for each query. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
last_result_sizeto ruby bindingsThis PR introduces a new method
last_result_sizeto the Trilogy gem's Ruby bindings. This method allows users to retrieve the exact byte size of the last result received from a query. The byte size includes not only the raw data but also headers, metadata, and any other protocol overhead.Main changes:
Note on the test
The test checks that the
last_result_sizefalls within a specific range (150 to 170 bytes). The reason for using a range instead of an exact value is to account for potential changes in the future. For example, changes in how headers or metadata are sent could affect the total byte size. The range provides a buffer to accommodate any of these changes.